Fix/start stop message format #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i could also just remove the vars from the cmdr.info statements all together instead. either way works for me. |
|
i dont think i like the mismatch of "container" and "subsystem name" |
kbdharun
approved these changes
Nov 15, 2024
taukakao
reviewed
Nov 15, 2024
- remove name from started/stopped message - updated en starting/stopping strings to include subsystem name
jardon
force-pushed
the
fix/start-stop-message-format
branch
from
f3ee223
to
461147d
Compare
|
@kbdharun i updated the strings to say subsystem instead. you good with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes two changes:
%sto starting/stopping messagesthe second change cleans up the output of the command output which in the case of starting/stopping, silences the distrobox printing the container name for no good reason. this can be dropped or split out if requested.
closes #431