Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[close #25] Automate Versioning #323

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jardon
Copy link
Member

@jardon jardon commented Jul 20, 2024

  • Go build defaults to development
  • Tag releases override to use the github.ref_name (tag name).
  • Continuous releases override to use commit sha
  • Remove VERSION file

@jardon
Copy link
Member Author

jardon commented Jul 20, 2024

@kbdharun thoughts on default being development? My thought is that it distinguishes something that is locally built versus whats built in CI

@kbdharun
Copy link
Member

kbdharun commented Jul 20, 2024

@kbdharun thoughts on default being development? My thought is that it distinguishes something that is locally built versus whats built in CI

Sure that too works IG, btw for the flag setting version as continuous in go.yml would it be possible to add a identifier like date of build commit SHA along with it so that it allows for easier debugging in future.

@taukakao
Copy link
Member

Closes #25
(For issue tracking)

@kbdharun kbdharun linked an issue Jul 20, 2024 that may be closed by this pull request
- Go build defaults to `development`
- Tag releases override to use the `github.ref_name` (tag name).
- Continuous releases override to use commit sha
- Remove `VERSION` file
@kbdharun kbdharun merged commit 27d1cd8 into Vanilla-OS:main Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate "Version"
4 participants