Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move mass unit conversion into util and add tooltip event #915

Open
wants to merge 1 commit into
base: 1.18.x/main
Choose a base branch
from

Conversation

alex-s168
Copy link
Contributor

@alex-s168 alex-s168 commented Jul 22, 2024

title

I did this because I need to display mass values in item tooltips in Tournament and other addons might want to do similar things

I'm not really happy with the mass tooltips ("old" feature) beeing in the main mod class, but I don't know where to move the code to

@ewoudje
Copy link
Contributor

ewoudje commented Jul 25, 2024

Could you move the mixin in its own feature, and instead of having a even abstraction just doing it directly.
Im assuming the tooltips event is for tournament use too but VS2 isn't an util library for anything except physics. You would only be depending on stuff that could be changed anytime.

@alex-s168
Copy link
Contributor Author

Could you move the mixin in its own feature, and instead of having a even abstraction just doing it directly. Im assuming the tooltips event is for tournament use too but VS2 isn't an util library for anything except physics. You would only be depending on stuff that could be changed anytime.

When depending on VS2, we depend on something that changes a lot anyways.
Is it bad to have more features that don't need maintaining?
also VS2 is already doing the mixin and we already have an event system.
it is almost free to combine those...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants