-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial progress towards a backwards-compatible API #608
Open
Rubydesic
wants to merge
13
commits into
1.18.x/main
Choose a base branch
from
1.18.x/api
base: 1.18.x/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the when |
Some way to access all constraints, id say expose a iterator? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
VS2, in development since 2019, was conceived as a library mod enabling other mods (addons) to utilize its physics code for diverse gameplay experiences beyond steampunk. Over four years, this vision materialized with addons like Eureka, Clockwork, Valkyrien Computers, and Tournament, ushering in a new era for Valkyrien Skies. Despite this, an officially supported, backward-compatible API was absent, until now.
Terminology
api
: New stable API moduleWhy
Valkyrien Skies updates can disrupt addons that rely on modified or removed public classes, necessitating updates from the addon developer. Until now, addons have been directly depending on Valkyrien Skies' internals, the API of which is in constant flux. This imposes a burden on developers and users, resulting in unnecessary updates and compatibility issues.
What
This PR introduces
api
, a new module for addon developers. It contains essential functions from VS2 internals needed for addon development. We commit to maintaining theapi
module and only making non-backward-compatible changes when absolutely necessary. Addons using elements solely from theapi
module should not require frequent updates to support new VS2 versions.Some crucial classes for addon development may still be missing from this PR. Addon developers are encouraged to communicate any additions they'd like to see in
api
.Future Plans
Experimental APIs
Certain parts of the API may be labeled with an
@Experimental
annotation. These may not be maintained in a backward-compatible manner. We will introduce a config flag in VS2 to enable these experimental APIs, ensuring user transparency, a-la Java 17's strong encapsulation.Blocking Internal Access
To prevent addons from inadvertently relying on internals and causing confusion for users when VS2 updates, we will gradually restrict access to various parts of VS2 internals for addons.
Other changes
For VS2 contributors, this PR significantly changes the structure of the Gradle multiproject build. It uses the Kotlin DSL for Gradle rather than the Groovy one, and it also introduces a second set of subprojects (
api:common
,api:fabric
,api:forge
) forapi
. We also use precompiled script plugins rather than Gradleallprojects
/subprojects
block for configuration. The oldfabric
,forge
, andcommon
projects are now located in thebase
directory.Footnotes
For the technical-minded among you, when I say "API", I am also referring to the ABI ↩