Fix for some entities crashing when getting added to a constructed ship. #1006
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a check against the entity's renderer to see if it is eligible for rendering before it calls the render function. This prevents crashes from occurring where an entity may not be ready to render yet, i.e. in the case of Mekanism's Universal Cables. Also changed the way the java version is set for the project, so developers that have multiple java versions installed can still use this project without needing to reset their java home to java 17.
|
|
|
See Mekanism thread for vis: mekanism/Mekanism#8260 |
…entation so we can use it in game as well.
|
Please leave the Java release/compiler options in place. The toolchain stuff is fine but you don't need to remove the previous settings. |
|
I don't really understand why this patch does anything. We're calling |
|
I did more testing and found that this causes beds and other uniquely rendered things to be invisible so this isn't a good fix. I think my original null check in Mekanism is the best approach to solve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a check against the entity's renderer to see if it is eligible for rendering before it calls the render function. This prevents crashes from occurring where an entity may not be ready to render yet, i.e. in the case of Mekanism's Universal Cables.
Also changed the way the java version is set for the project, so developers that have multiple java versions installed can still use this project without needing to reset their java home to java 17.