tracing-subscriberをv0.3に上げる #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Apr 23, 2023
| @@ -31,10 +31,10 @@ ureq = { version = "2.1", optional = true } | |||
|
|
|||
| [dev-dependencies] | |||
| image = "0.23" | |||
| test-env-log = { version = "0.2", default-features = false, features = [ | |||
| test_env_log = { package = "test-log", version = "0.2", default-features = false, features = [ | |||
There was a problem hiding this comment.
VOICEVOX/voicevox_core#427を考えるとnbigaouette/onnxruntime-rsとの差分をできるだけ減らしておきたいので、リネームすることで#[test_env_log::test]の形で使える状態を保つ。
| "trace", | ||
| ] } | ||
| tracing-subscriber = "0.2" | ||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } |
There was a problem hiding this comment.
v0.2 → v0.3でtracing_subscriber::fmt::SubscriberBuilder::with_env_filterがfeature-gateされたので、featureを指定。
Hiroshiba
approved these changes
Apr 23, 2023
|
PRありです！！ マージします！！ |
あーRustが1.69になってましたね。忘れてました。Rust本体の何をどう踏んづけたらあんなエラーになったのかは個人的に気になるところではありますが、まあ直ったし… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
tracing-subscriberをv0.2 → v0.3に上げることで、CIが謎に落ちている状態を解消します。
#21 (comment)
よくわかりませんがこれで直るようです。
https://github.com/qryxip/onnxruntime-rs/actions/runs/4775863128/jobs/8490490491
関連 Issue
スクリーンショット・動画など
その他
このリポジトリで使われている、tracing-subscriberを内部で使っているtest-env-logですが、"test-log"に改名したということでdeprecatedになっており、microsoft/onnxruntimeの方では既にそっちに切り替わってます。このライブラリがもしかしたら今回の問題の原因の一端なんじゃないかと疑っています。
ただ移行を考えるとこのリポジトリのは放置でいいかも。いや#[deprecated]によるwarningも出てますし、Cargo.tomlを追加で一行変更するだけでいいので今やった方がいいですね。