fixing notebook #21
Merged
fixing notebook #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
For me the changes with jupyter notebook works. I tested with the second example data folder which contains a new version of the files compared to example study1. |
qubixes
requested changes
Nov 25, 2024
src/validation_pipeline.ipynb
Outdated
| @@ -107,7 +108,7 @@ | |||
| "metadata": {}, | |||
| "outputs": [], | |||
| "source": [ | |||
| "proj_data_path = Path.cwd().parent / \"data\" / \"synthetic_data\"\n", | |||
| "proj_data_path = Path.cwd().parent / \"data\" / \"synthetic_data_2\"\n", | |||
There was a problem hiding this comment.
What is synthetic_data_2? Perhaps we can give it a better name? Does the old one still work, some explanation here would be helpful.
There was a problem hiding this comment.
Renamed to "test_data"
Co-authored-by: qubixes <44498096+qubixes@users.noreply.github.com>
Co-authored-by: qubixes <44498096+qubixes@users.noreply.github.com>
Co-authored-by: qubixes <44498096+qubixes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jupyter notebook is adjusted to the new backend.
It replicates each step of the validation pipeline and gives a bit more information.