fix: client synchronization edge case interruption [MTT-7100] #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
changed the title
ShadauxCat
approved these changes
Aug 10, 2023
|
Closing this PR as there is a root cause to the exception discovered and the fix requires a different approach. |
NoelStephensUnity
deleted the
fix/client-synchronization-edge-case-interruption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a catch to
NetworkSceneManager.SynchronizeNetworkObjectScenein order to prevent an edge case exception from happening during the very end of the initial client synchronization process so that the client will still send the host-server the synchronization complete message.Adding additional precision logging to NetworkTransformTests.ParentedNetworkTransformTest so we can determine what the proper half precision threshold setting should be in the event it fails again.
MTT-7100