Add Tests for maxUsableTick and minUsableTick Functions #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partylikeits1983
changed the title
hensha256
reviewed
Mar 26, 2024
hensha256
reviewed
Mar 26, 2024
Comment on lines
+106
to
+111
| function test_maxUsableTick_equalsMinUsableTick_fuzz(int24 tickSpacing) public { | ||
| tickSpacing = int24(bound(tickSpacing, TickMath.MIN_TICK_SPACING, TickMath.MAX_TICK_SPACING)); | ||
| vm.assume(tickSpacing != 0); | ||
|
|
||
| assertEq(-tickMath.minUsableTick(tickSpacing), tickMath.maxUsableTick(tickSpacing)); | ||
| } |
There was a problem hiding this comment.
@hensha256 resolving this suggestion from @aadams on my previous PR
#468 (comment)
Comment on lines
+90
to
+96
| function test_maxUsableTick_shouldMatchExpectedMaxTickGivenSpacing_fuzz(int24 tickSpacing) public { | ||
| tickSpacing = int24(bound(tickSpacing, TickMath.MIN_TICK_SPACING, TickMath.MAX_TICK_SPACING)); | ||
| vm.assume(tickSpacing != 0); | ||
|
|
||
| int24 expectedMaxTick = (MAX_TICK / tickSpacing) * tickSpacing; | ||
| assertEq(tickMath.maxUsableTick(tickSpacing), expectedMaxTick); | ||
| } |
There was a problem hiding this comment.
@hensha256 Using bound instead of vm.assume and using TickMath.MIN_TICK_SPACING and TickMath.MAX_TICK_SPACING instead of MIN_TICK and MAX_TICK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hensha256 @aadams Following up on the stale PR: #468
This commit introduces tests for the newly added utility functions
maxUsableTickandminUsableTickin the TickMath library.Added tests to check the min and max usable ticks in the
TickMathlibrary.Added 2 tests to check tick spacings for popular fee tiers.
Added 2 fuzzing tests.
Added 2 tests to check revert of min/max tick on 0.