Find references crash fix #1947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move check for language to only be done on bytecode version 16 and up. See https://github.com/UnderminersTeam/UndertaleModTool/wiki/Bytecode-version-differences. Fixes UnderminersTeam#1946.
|
Download the artifacts for this pull request here: GUI:
CLI: |
This was referenced Oct 13, 2024
maxiterr1
approved these changes
Oct 19, 2024
colinator27
requested changes
Oct 23, 2024
UndertaleModTool/Windows/FindReferencesTypesDialog/UndertaleResourceReferenceMethodsMap.cs
Outdated
Show resolved
Hide resolved
colinator27
approved these changes
Oct 23, 2024
Miepee
reviewed
Nov 25, 2024
| dialog = new(data, results); | ||
| dialog.Show(); | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
can we somehow trickle the exception type further instead of just having a catchall?
Miepee
requested changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1946 by only checking language for bytecode 16 and above games.
Based on https://github.com/UnderminersTeam/UndertaleModTool/wiki/Bytecode-version-differences.
Also adds error handling to all functions which use GetReferencesOfObject so if something similar happens again it won't cause the tool to crash.
Caveats
Notes
Replaces #1942.
Thanks to @maxiterr1 for bringing this to my attention.