Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DV Tests to UltreonLib Tests #83

Open
wants to merge 5 commits into
base: 1.20.1
Choose a base branch
from
Open

Move DV Tests to UltreonLib Tests #83

wants to merge 5 commits into from

Conversation

XyperCode
Copy link
Member

Using the UltreonLib Test Screen API we can remove the need of the DV TEST buttons in the title screen.

Extra Dependencies:

@XyperCode XyperCode requested a review from Jab125 October 16, 2023 22:16
@XyperCode XyperCode self-assigned this Oct 16, 2023
@XyperCode XyperCode added the enhancement New feature or request label Oct 16, 2023
@XyperCode XyperCode marked this pull request as ready for review October 16, 2023 23:15
Jab125
Jab125 requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Jab125 Jab125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, make sure the mod doesn't need to have UltreonLib in production

common/src/main/java/com/ultreon/devices/core/client/debug/ClientAppDebug.java Outdated Show resolved Hide resolved
@XyperCode
Copy link
Member Author

XyperCode commented Oct 24, 2023 •
edited
Loading

Also, make sure the mod doesn't need to have UltreonLib in production

I doesn't need it on prod. yet.
But 2.0 will require it probably.

@XyperCode XyperCode requested a review from Jab125 February 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jab125 Jab125 Awaiting requested review from Jab125

Requested changes must be addressed to merge this pull request.

Assignees

@XyperCode XyperCode

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XyperCode @Jab125