-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/packaging #15
Conversation
This requires minor changes in |
src/sastadev/conf.py
Outdated
def __init__(self, | ||
ALPINO_HOST: str = 'localhost', | ||
ALPINO_PORT: int = 7001, | ||
LOGGER=logging, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to use logging.getLogger('sastadev')
instead of the root logger, giving more control to downstream users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I'll alter the main script a little bit to also work with that configuration.
print('Configuration initiated.') | ||
|
||
|
||
settings = SastadevConfig() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe prefer having no settings by default, and getting an exception that says I have to initialize sastadev before using any of its functionality. (Or at least a warning, in case you don't want to introduce breaking changes)
Otherwise it could be hard to tell whether something was imported before being configured.
generatemacros.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this file deleted. The content is needed. Have you moved it elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is copied to src/sastadev/generatemacros.py
. Somehow Git didn't pick register it as move
but delete
of the old file +create
of the new file.
This PR aims to make a full package out of
sastadev
.sastadev
modules, rather than a limited subset.sasta
andsastadev
run well.For the individual reviewers:
@JanOdijk
sastadev
references in yourPATH
are removed, so only the installed package is read.@bbonf , @Meesch
auchann
? Clone, install locally (e.g. `pip install /Users/my_name/projects/sastadev' and run the tests.