use xpyth-parser for parsing xpath #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm not sure why this wasn't merged earlier |
|
Apparently xpyth-parser doesn't handle (some of) the queries we use for MWE. So this requires more work. |
bbonf
added a commit
that referenced
this pull request
Dec 19, 2023
* updated requirements * redo pip-compile with python 3.8 * fix type warning * trying to fix deployment * explicitly ask for psycopg2 in requirements * About page * use xpyth-parser for parsing xpath (#91) * use xpyth-parser for parsing xpath * added a comment * Revert "use xpyth-parser for parsing xpath (#91)" This reverts commit e4531f4. * update to a newer version of mwe-query with fixes (#95) * updated tree expansion method * allow searching for canonical forms in admin panel --------- Co-authored-by: Sheean Spoel <s.j.j.spoel@uu.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using lxml's XPath parser to validate search queries, but it only supports XPath 1.0
This causes some legal queries to fail validation (see #65)
The xpyth_parser library supports XPath 3.1, which should match BaseX.