Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ethers types to contracts-node and contracts-frontend #4572

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrice32
Copy link
Member

@mrice32 mrice32 commented Jun 9, 2023

Motivation

Importing ethers event types from contracts-node doesn't work.

Summary

You can now import ethers event types by doing the following:

import { MyContractEthersTypes } from "@uma/contracts-node";

const myVar: MyContractEthersTypes.SomeEvent = ...

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

  • Ran end-to-end test, running the code as in production
  • New unit tests created
  • Existing tests adequate, no new tests required
  • All existing tests pass
  • Untested

Issue(s)

N/A

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
@mrice32 mrice32 marked this pull request as draft July 17, 2023 12:37
Copy link
Contributor

@md0x md0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix would be useful!

This is how I was importing event types:
https://github.com/UMAprotocol/protocol/blob/master/packages/monitor-v2/src/monitor-polymarket/MonitorProposalsOrderBook.ts#L2

Do we want to add this changes @mrice32 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants