Create all variables directly from connection and independent of dataframes #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
- Coverage 98.76% 96.17% -2.59%
==========================================
Files 30 30
Lines 1210 1202 -8
==========================================
- Hits 1195 1156 -39
- Misses 15 46 +31 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
abelsiqueira
force-pushed
the
923-variable-refactor-wip
branch
2 times, most recently
from
f52d260
to
fcf9833
Compare
abelsiqueira
changed the title
5 tasks
abelsiqueira
commented
Nov 25, 2024
Comment on lines
+249
to
+283
| # The logic: | ||
| # - t_union has groups in order, then s:e ordered by s increasing and e decreasing | ||
| # - in a group (asset, year, rep_period) we can take the first range then | ||
| # - continue in the sequence selecting the next largest e |
There was a problem hiding this comment.
Use
- 1:4 5:8 9:12
- 1:3 4:4 5:9 10:12
1 2 3 4
o o o o
o o o
o o o o
o o o o
o o o o o
o o o o
o o o
o o o o
o
Separate creation of union and lowest resolution tables from storage_level_intra_rp creation. Closes #923
abelsiqueira
force-pushed
the
923-variable-refactor-wip
branch
from
fcf9833
to
d173c99
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #925
Create all variables with connection instead of dataframes variable.
With the
lookupcreated in #925, this allow us toClose #923