Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DuckDB to 1, (keep existing compat) #845

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 8, 2024

This pull request changes the compat entry for the DuckDB package from 0.10, ~1.0 to 0.10, ~1.0, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@clizbe clizbe force-pushed the compathelper/new_version/2024-10-08-01-49-53-272-03116567005 branch from 251af1c to 1f0453e Compare October 8, 2024 01:49
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (f50fd5d) to head (1f0453e).

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #845      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%     
===========================================
  Files           20       20              
  Lines         1021     1017       -4     
===========================================
- Hits          1021     1016       -5     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada marked this pull request as draft October 9, 2024 13:54
@datejada
Copy link
Member

Putting this as a draft until the DuckDB issue is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant