Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub release workflow #87

Merged
merged 1 commit into from
Aug 30, 2024
Merged

GitHub release workflow #87

merged 1 commit into from
Aug 30, 2024

Conversation

karlobencic
Copy link
Contributor

@karlobencic karlobencic commented Aug 30, 2024

Added a Release workflow that triggers on pushes to the main branch. The workflow uses changesets to automate creating release PRs or directly publishing to npm registry.

@karlobencic karlobencic changed the title Feature/GitHub action publish GitHub release workflow Aug 30, 2024
@cyraxx
Copy link
Contributor

cyraxx commented Aug 30, 2024

Interesting, I've never worked with changesets but I'm willing to give it a try.

A couple questions:

  • How does this decide where to publish the package to? Isn't there some configuration missing to publish to GitHub package registry? (And npm, later)
  • Should there be an automated check in PRs that make sure there's a changeset attached?

@karlobencic
Copy link
Contributor Author

Interesting, I've never worked with changesets but I'm willing to give it a try.

A couple questions:

  • How does this decide where to publish the package to? Isn't there some configuration missing to publish to GitHub package registry? (And npm, later)
  • Should there be an automated check in PRs that make sure there's a changeset attached?

I've set npm registry url in the release action.

It is possible to set an alert in case of a missing changeset https://github.com/changesets/changesets/blob/main/docs/checking-for-changesets.md

Copy link
Contributor

@cyraxx cyraxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I will add the bot then

add initial release changeset

set registry url
Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 1e92d8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
c2pa-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karlobencic karlobencic merged commit 29b3add into main Aug 30, 2024
3 checks passed
@karlobencic karlobencic deleted the feature/github-action-publish branch August 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants