Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CA Host SIDs to $SafeUsers, Not Names #139

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

TrimarcJake
Copy link
Owner

This PR updates the $SafeUsers generation section to use CA Host SIDs instead of Names because use SIDs almost everywhere instead of Names.

Copy link

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 16 1.97s
⚠️ EDITORCONFIG editorconfig-checker 16 1 0.2s
⚠️ MARKDOWN markdownlint 5 15 0.53s
⚠️ MARKDOWN markdown-link-check 5 8 4.07s
✅ MARKDOWN markdown-table-formatter 5 0 0.22s
⚠️ POWERSHELL powershell 11 8 17.71s
✅ POWERSHELL powershell_formatter 11 0 12.31s
⚠️ REPOSITORY checkov yes 1 11.1s
✅ REPOSITORY gitleaks yes no 0.32s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.31s
✅ REPOSITORY secretlint yes no 0.85s
✅ REPOSITORY trivy yes no 6.15s
✅ REPOSITORY trivy-sbom yes no 2.75s
✅ REPOSITORY trufflehog yes no 8.91s
⚠️ SPELL cspell 17 189 6.52s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@TrimarcJake
Copy link
Owner Author

Resolves #138

@TrimarcJake TrimarcJake merged commit e522141 into testing Jul 23, 2024
3 checks passed
@TrimarcJake TrimarcJake deleted the 138-check-SID-not-DN branch July 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant