-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early draft of ESC9 checks #113
Conversation
…into dev-12-esc9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to add DC checks into this before merging with testing
?
$path = "CN=Certificate Templates,CN=Public Key Services,CN=Services,$configNC" | ||
|
||
# Get all certificate templates | ||
$templates = Get-ADObject -Filter * -SearchBase $path -Properties msPKI-Enrollment-Flag, msPKI-Certificate-Name-Flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these properties actually pull properly without being wrapped in quotes?
TBD. I haven't looked at this since December and don't think it's complete yet. Just sharing a draft PR in case anyone else had started also working on ESC9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sharing this early December draft of ESC9 checks to gage interest in possibly completing and adding it to the project. This could also be moved to its own branch on the upstream repo to make it easier to collaborate on this specific check.