Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early draft of ESC9 checks #113

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

SamErde
Copy link
Collaborator

@SamErde SamErde commented Feb 16, 2024

Sharing this early December draft of ESC9 checks to gage interest in possibly completing and adding it to the project. This could also be moved to its own branch on the upstream repo to make it easier to collaborate on this specific check.

@SamErde SamErde added enhancement New feature or request help wanted Extra attention is needed labels Feb 16, 2024
Copy link
Owner

@TrimarcJake TrimarcJake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to add DC checks into this before merging with testing?

$path = "CN=Certificate Templates,CN=Public Key Services,CN=Services,$configNC"

# Get all certificate templates
$templates = Get-ADObject -Filter * -SearchBase $path -Properties msPKI-Enrollment-Flag, msPKI-Certificate-Name-Flag
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these properties actually pull properly without being wrapped in quotes?

@SamErde
Copy link
Collaborator Author

SamErde commented Feb 17, 2024

TBD. I haven't looked at this since December and don't think it's complete yet. Just sharing a draft PR in case anyone else had started also working on ESC9.

Copy link
Owner

@TrimarcJake TrimarcJake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TrimarcJake TrimarcJake merged commit 38cb477 into TrimarcJake:testing Feb 26, 2024
3 checks passed
@SamErde SamErde deleted the dev-12-esc9 branch February 26, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants