Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the installed version of Locksmith is recent or out of date #100

Merged
merged 16 commits into from
Feb 10, 2024

Conversation

SamErde
Copy link
Collaborator

@SamErde SamErde commented Jan 16, 2024

Compares the installed version of Locksmith to the version on GitHub. If older than [x] days (default is 90), it recommends the user to update. If unable to reach GitHub, it extrapolates the installed version's release date and recommends an update if necessary.

Will submit PR to include this check in main function after testing and validation by the team.

@SamErde SamErde added the enhancement New feature or request label Jan 16, 2024
@SamErde SamErde self-assigned this Jan 16, 2024
@SamErde
Copy link
Collaborator Author

SamErde commented Jan 17, 2024

After mostly completing this, I thought it might be better to target the PowerShell Gallery instead of GitHub for version checks. I've worked at orgs that blocked GitHub downloads but didn't actively block the PowerShell Gallery. Thoughts?

@TrimarcJake
Copy link
Owner

Why not both?

@SamErde
Copy link
Collaborator Author

SamErde commented Jan 17, 2024

Want to minimize the time it takes to run this check on the client.

We'll need to figure out whether to run this automatically or provide a switch to let the user run the check during execution.

@SamErde
Copy link
Collaborator Author

SamErde commented Jan 17, 2024

... But at this point, it shouldn't be too hard to use the Gallery or GitHub as backup checks for each other in case one check fails.

@SamErde SamErde added the help wanted Extra attention is needed label Jan 19, 2024
Copy link
Owner

@TrimarcJake TrimarcJake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding using PS Gallery vs. GitHub, let's focus on getting GH rock-solid. The people using this tool will likely have GH access anyway.

Private/Get-ModuleAge.ps1 Outdated Show resolved Hide resolved
Private/Get-ModuleAge.ps1 Outdated Show resolved Hide resolved
Private/Get-ModuleAge.ps1 Outdated Show resolved Hide resolved
Private/Get-ModuleAge.ps1 Outdated Show resolved Hide resolved
Copy link
Owner

@TrimarcJake TrimarcJake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I am going to merge it with testing and then work on moving a few things around in a future release. I also feel like this could be at least 2 but maybe even three functions!

@TrimarcJake TrimarcJake merged commit cba7c3e into TrimarcJake:testing Feb 10, 2024
3 checks passed
@SamErde SamErde deleted the dev-01-version-check branch February 10, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants