🌌 Use build.rustflags
(and variants) as a replacement for environment variable to enable spaces in paths
#3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-mobile#128
As per the docs https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags
Using the
build.rutflag
approach allows for spaces in paths, as seen in https://github.com/rust-lang/docs.rs/blob/bcc1a2c9f63a62907abbe68dcbe3f73632a9a4de/crates/metadata/lib.rs#L256-L262Additionally, as suggested in rust-mobile#128 (comment),
setting
CC_SHELL_ESCAPED_FLAGS=1
and inserting quotes around paths that are passed toC(XX)FLAGS
solves all the remaining issues (provided that cc-rs is updated to 1.1.11)