Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGIN and IGNORE_CONFLICT params #27

Closed
wants to merge 4 commits into from
Closed

Conversation

Natgho
Copy link

@Natgho Natgho commented Oct 25, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #27 (73c8cec) into main (b600d7d) will decrease coverage by 0.40%.
The diff coverage is 42.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   86.14%   85.75%   -0.40%     
==========================================
  Files          19       20       +1     
  Lines        1537     1551      +14     
  Branches      228      232       +4     
==========================================
+ Hits         1324     1330       +6     
- Misses        183      190       +7     
- Partials       30       31       +1     
Files Coverage Δ
src/dj_tracker/constants.py 100.00% <ø> (ø)
src/dj_tracker/promise.py 95.91% <100.00%> (+0.01%) ⬆️
src/dj_tracker/urls.py 73.33% <60.00%> (-6.67%) ⬇️
src/dj_tracker/urlpatterns.py 25.00% <25.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Natgho Natgho closed this Oct 25, 2023
@Tijani-Dia
Copy link
Owner

@Natgho Thanks for opening these.

I'd suggest opening separate PRs for each feature to make things easier to review.

I'm unsure about the ignore_conflicts addition. As I said, I've been working on making it work with multiple processes but I'm taking a whole different approach. Moreover, we'll need to ensure that the ignore_conflicts actually works.

@Natgho
Copy link
Author

Natgho commented Oct 25, 2023

Hi,

Yes you are right, I only put the login feature in this PR. I leave the other issue to you, I can help the code if you open it as a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants