Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the metadata title in Android player controls #4265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fredrifoUni
Copy link

@fredrifoUni fredrifoUni commented Oct 29, 2024

Summary

Integrates the video title into the Android player controls. This is already automatically handled by iOS through the source.metadata.title prop.

Note:

  • We only use the title for our TV project so the styling may not be great for Android phones.

Copy link
Collaborator

@freeboub freeboub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will impact all client apps, so you need to make it modular:

@freeboub
Copy link
Collaborator

@fredrifoUni I would be happy to merge this soon, can you please have a look to my comment

@fredrifoUni
Copy link
Author

@fredrifoUni I would be happy to merge this soon, can you please have a look to my comment

These changes were taken directly from our fork, so I don't know if I'll be able to allocate work hours for this unfortunately. I may be able to revisit it after PR-3914 has been merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants