Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pausing webhooks #7401

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Pausing webhooks #7401

merged 3 commits into from
Nov 26, 2024

Conversation

mjamescompton
Copy link
Contributor

Summary

Reference #7223

Changes

  • Add Pause/play button to edit webhook view with modal
  • Add paused notification to edit webhook view
  • Fix missing shared message reactivateSuccess
  • Fix status icon alignment style

Testing

Steps

See issue for more details on creating an active webhook

For this task

  • Create a webhook

  • Open webhook edit form for example /console/applications/abc/integrations/webhooks/pausing-webhooks

  • Go to the bottom of the page and click the pause icon, the modal should open and then click Pause webhook

  • Try reactivating the webhook using either the notification at the top of the edit form or using the play button at the bottom of the page.

In each state you can see if your webhook if getting to it destination and also check the status on the list view
/console/applications/abc/integrations/webhooks

Results

Pause webhook

Screenshot 2024-11-22 at 10 51 41 Screenshot 2024-11-22 at 10 51 44

Activate webhook

Screenshot 2024-11-22 at 10 51 24 Screenshot 2024-11-22 at 10 51 31

List view

Health status enabled
Screenshot 2024-11-22 at 10 51 54
Health status disabled
Screenshot 2024-11-22 at 10 52 27
Regressions

...

Notes for Reviewers

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@mjamescompton mjamescompton self-assigned this Nov 22, 2024
@mjamescompton mjamescompton requested a review from a team as a code owner November 22, 2024 09:59
@github-actions github-actions bot added the ui/web This is related to a web interface label Nov 22, 2024
@pierrephz pierrephz self-requested a review November 22, 2024 11:02
Copy link
Contributor

@pierrephz pierrephz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some UI fixes that can be done:

Pausing webhook

@KrishnaIyer if you think of a better text for the modal let us know

@KrishnaIyer
Copy link
Member

Text for Pause Webhook: When a webhook is paused, messages will not be forwarded to the configured end point and will be dropped.

Text above Activate Webhook: This webhook is currently paused and no messages are forwarded to the configured end point.

@KrishnaIyer KrishnaIyer added this to the v3.33.0 milestone Nov 22, 2024
@mjamescompton
Copy link
Contributor Author

Screenshot 2024-11-22 at 13 55 28 Screenshot 2024-11-22 at 13 55 45 Screenshot 2024-11-22 at 13 55 52 Screenshot 2024-11-22 at 13 55 56 Screenshot 2024-11-22 at 13 56 07

Here are the updates

I'm working on a cypress test now

Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjamescompton mjamescompton merged commit 9271ad8 into v3.33 Nov 26, 2024
12 of 13 checks passed
@mjamescompton mjamescompton deleted the feature/pause-webhooks branch November 26, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants