Fix formatting of long lane names (PP-1962) #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdilauro
approved these changes
Nov 22, 2024
| @@ -27,7 +27,6 @@ | |||
| display: block; | |||
| background: darken($gray-tint, 5); | |||
| padding: 6px 12px; | |||
| height: 34px; | |||
There was a problem hiding this comment.
This change is probably safe, but in order to ensure that the element doesn't collapse if it has content that doesn't intrinsically have height of its own, I would suggest changing this property to
min-height: 34px;rather than removing height altogether. That will prevent the element collapsing, but will allow it to grow as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the work editor long lane names were being formatted poorly. Found this while working on PP-1962.
Motivation and Context
Before this change:
After:
I took a look around the admin interface after making this change, and I don't see any ill effects, but I'm not 100% sure everywhere this style-sheet is used, so its possible there is a better way to approach this.
How Has This Been Tested?
Checklist: