Removed the Android 12+ devices default splash screen. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io7m
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This PR removes the default SplashScreen added in all the Android 12+ devices by setting a theme with a translucent status when launching the app on an Android 12+ (the other versions remain unchanged and with the original theme) and set the original app's theme when the default splash screen is dismissed.
Why are we doing this? (w/ JIRA link if applicable)
There's a bug report saying that in some devices there are two splash screens being shown: the device's default and the app's splash screen.
How should this be tested? / Do these changes have associated tests?
Follow this PR's reproducing steps
Dependencies for merging? Releasing to production?
This PR needs to be merged to test this
Have you updated the changelog?
Yes
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
Tested by @nunommts