Feature/add support to epub text searching #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/add-support-to-epub-text-searching # Conflicts: # README-CHANGES.xml
io7m
reviewed
Sep 22, 2023
| } | ||
| this.supportFragmentManager.beginTransaction() | ||
| .add(R.id.reader2FragmentHost, this.readerFragment) | ||
| .commit() |
There was a problem hiding this comment.
We aren't reusing fragment instances anymore?
Not that I mind, but ... does this have lifecycle repercussions?
There was a problem hiding this comment.
We are. This adds the reader fragment and then all the operations on fragments are just showing/hiding the current instances (or add one if it's not added already) so there's no recreation of fragments. In the end, when we leave the screen all the instances are destroyed alongside with the activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This PR adds support to the EPUB text searching by handling the logic of showing/hiding the SearchFragment
Why are we doing this? (w/ JIRA link if applicable)
There's a feature request to include the EPUB text searching in the Palace app.
How should this be tested? / Do these changes have associated tests?
Open the Palace app
Select any EPUB
Click on the search icon
Type any query
Click on one of the results
Confirm you're redirected to that part of the book
Dependencies for merging? Releasing to production?
This PR also needs to be merged
Have you updated the changelog?
Yes
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
Tested by @nunommts