PP-307: Resume account views correctly #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code was failing to set usernames/passwords for token auth, and also failing to reconfigure the UI in the `onStart()` method. This would cause inconsistent visuals when resuming the app after having locked the screen. Affects: https://ebce-lyrasis.atlassian.net/browse/PP-307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
The current code was failing to set usernames/passwords for token auth,
and also failing to reconfigure the UI in the
onStart()method. Thiswould cause inconsistent visuals when resuming the app after having
locked the screen.
Why are we doing this? (w/ JIRA link if applicable)
https://ebce-lyrasis.atlassian.net/browse/PP-307
How should this be tested? / Do these changes have associated tests?
Try locking the device when on the account details screen, and then unlocking it. See the video in PP-307 for an example of what shouldn't happen. 🙂
Dependencies for merging? Releasing to production?
None.
Have you updated the changelog?
Yes.
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@io7m Tried lots of locking and unlocking.