PP-443: Restrict cover widths #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets a maximum width for covers in lanes and book detail pages. Affects: https://ebce-lyrasis.atlassian.net/browse/PP-443
nunommts
suggested changes
Sep 20, 2023
|
|
||
| <androidx.cardview.widget.CardView | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
There was a problem hiding this comment.
Since there's just a CardView, do we need a parent view? If so, maybe we should use a FrameLayout instead then
There was a problem hiding this comment.
I freely admit I have no idea. I've not looked at any of the UI code for years, and even then, I wasn't the person who wrote it.
What arrangement of layouts were you thinking of?
<FrameLayout>
<CardView>
<ImageView/>
</CardView>
</FrameLayout>
Like that?
There was a problem hiding this comment.
Removing the parent view completely seems to work fine!
There was a problem hiding this comment.
Cool! But for the record, I was thinking about this (like you said), if we were not to remove the parent view:
<FrameLayout>
<CardView>
<ImageView/>
</CardView>
</FrameLayout>
nunommts
suggested changes
Sep 20, 2023
nunommts
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This sets maximum widths for covers so that very large covers can no longer break the UI.
Before:
After:
Why are we doing this? (w/ JIRA link if applicable)
https://ebce-lyrasis.atlassian.net/browse/PP-443
How should this be tested? / Do these changes have associated tests?
Try Minotaur. The book is on the front page now.
Dependencies for merging? Releasing to production?
None.
Have you updated the changelog?
Yes.
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@io7m Took the screenshots above!