Additional validate_heex func #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en invalid template
leandrocp
reviewed
Mar 15, 2023
…onsistent Co-authored-by: Leandro Pereira <leandro@leandro.io>
alexandrexaviersm
force-pushed
the
feature/additional-validate_heex-function
branch
from
df06b10
to
c4a2ff0
Compare
leandrocp
approved these changes
Mar 15, 2023
TheFirstAvenger
requested changes
Mar 28, 2023
Comment on lines
+30
to
+33
| quoted = | ||
| heex | ||
| |> HeexParser.parse_template() | ||
| |> validate_quoted(include_phoenix(opts)) |
There was a problem hiding this comment.
Lets call directly into the other one, that way these two won't drift if a change is made to the parsing logic in one and doesn't get copied to the other version.
Suggested change
| quoted = | |
| heex | |
| |> HeexParser.parse_template() | |
| |> validate_quoted(include_phoenix(opts)) | |
| quoted = validate_heex!(heex, opts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional
validate_heexfunc that doesn't throw exceptions if the template is invalid.I discussed it with Leandro and we thought it would be worth having a version of this function that doesn't throw exception when the template is invalid. We believe that it would be useful in some cases in Beacon, for example, right now I'm solving the issue BeaconCMS/beacon#74 and this function would be very handy to add the template error into an invalid changeset.