Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multitype items #118

Merged
merged 19 commits into from
Nov 3, 2024
Merged

Handle multitype items #118

merged 19 commits into from
Nov 3, 2024

Conversation

0xCAB0
Copy link
Member

@0xCAB0 0xCAB0 commented Nov 2, 2024

Added SerDe support to deserialize items which may come as Integer or Bool.

@0xCAB0 0xCAB0 requested a review from pxp9 November 2, 2024 19:58
@0xCAB0 0xCAB0 self-assigned this Nov 2, 2024
@0xCAB0
Copy link
Member Author

0xCAB0 commented Nov 2, 2024

Another way of implementing custom Deserializer that may be more correct Visitor trait

@0xCAB0 0xCAB0 mentioned this pull request Nov 2, 2024
Merged
pxp9
pxp9 requested changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@pxp9 pxp9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work , just a couple comments.

README.md Show resolved Hide resolved
examples/filter_example/src/main.rs Show resolved Hide resolved
src/model/serde_config.rs Outdated Show resolved Hide resolved
src/queries.rs Outdated Show resolved Hide resolved
src/queries.rs Show resolved Hide resolved
src/queries.rs Show resolved Hide resolved
@0xCAB0 0xCAB0 added enhancement New feature or request rust Pull requests that update Rust code labels Nov 3, 2024
pxp9
pxp9 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@pxp9 pxp9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxp9 pxp9 merged commit 42793b6 into main Nov 3, 2024
6 checks passed
@pxp9 pxp9 deleted the fix/handle-multitype-items branch November 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp9 pxp9 pxp9 approved these changes

Assignees

@0xCAB0 0xCAB0

Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xCAB0 @pxp9