Fix played jingles (Path Complete and Plenary) briefly not respecting user volume #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
There seems to be a lot of confusion between user volume and game's master volume. As a result, a bug was introduced when the user volume setting was added in which for a single frame the music of these jingles was set to the VVV_MAX_VOLUME which may be much louder than the user's volume setting. This was especially noticeable for Path Complete, but could be heard in Plenary too (even with its baked-in fade). It might be a good idea to generally clean up the audio code because the different volume variables between user and master are peppered throughout the audio functions instead of being localized and processed in one place. Either way, this PR fixes the bug with the jingles (tracks 0 and 7).
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement