-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix compilation with Gestalt 8 #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what the error means:
package org.terasology.context.annotation
as it would not compile if this would not exist.
should the version be updated to 2.0.0 ? |
This change would increase the minimum engine version needed, so it may be a breaking change that warrants a new major version. It all depends on the perspective that you version modules from (module API vs jar ABI vs source API). I am not entirely sure at the moment. |
@soloturn This seems to be a GitHub check report caching issue in the "Files changed" view...
@BenjaminAmos We currently do not have a true notion of "module version abc depends on engine version xyz". Changing this is a bigger effort that we (IMO) should tackle in the future, but I don't think the time for that is now. Currently, module versions communicate changes that are visible to the player. This is no such change, so it shouldn't be a minor or major version bump. We can do a patch bump though, if we want, to indicate that something in the background technically works differently. |
- Inventory v1.5.0 was released, now gestalt 8 upgrade formerly merged as #54 can be reapplied
This pull request contains fixes to ensure that the module compiles under Gestalt 8.
This depends on MovingBlocks/Terasology#5267.