Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix compilation with Gestalt 8 #54

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Conversation

BenjaminAmos
Copy link
Contributor

This pull request contains fixes to ensure that the module compiles under Gestalt 8.

This depends on MovingBlocks/Terasology#5267.

soloturn
soloturn previously approved these changes Jul 29, 2024
Copy link
Contributor

@soloturn soloturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the error means:
package org.terasology.context.annotation

as it would not compile if this would not exist.

@soloturn
Copy link
Contributor

should the version be updated to 2.0.0 ?

@BenjaminAmos
Copy link
Contributor Author

This change would increase the minimum engine version needed, so it may be a breaking change that warrants a new major version. It all depends on the perspective that you version modules from (module API vs jar ABI vs source API). I am not entirely sure at the moment.

@jdrueckert
Copy link
Member

not sure what the error means: package org.terasology.context.annotation
as it would not compile if this would not exist.

@soloturn This seems to be a GitHub check report caching issue in the "Files changed" view...
If you click on the check run associated with the warning, you'll see that this ran 5 days ago (probably before the "publish" stage of the engine merge job was done). If you refresh to a later run, you'll see that the warning are gone.

This change would increase the minimum engine version needed, so it may be a breaking change that warrants a new major version. It all depends on the perspective that you version modules from (module API vs jar ABI vs source API). I am not entirely sure at the moment.

@BenjaminAmos We currently do not have a true notion of "module version abc depends on engine version xyz". Changing this is a bigger effort that we (IMO) should tackle in the future, but I don't think the time for that is now. Currently, module versions communicate changes that are visible to the player. This is no such change, so it shouldn't be a minor or major version bump. We can do a patch bump though, if we want, to indicate that something in the background technically works differently.

@jdrueckert jdrueckert merged commit 4dc6926 into develop Aug 3, 2024
11 checks passed
@jdrueckert jdrueckert deleted the feat/gestalt-8-upgrade branch August 3, 2024 11:41
@jdrueckert jdrueckert restored the feat/gestalt-8-upgrade branch August 3, 2024 12:58
jdrueckert added a commit that referenced this pull request Aug 4, 2024
- Inventory v1.5.0 was released, now gestalt 8 upgrade formerly merged as #54 can be reapplied
@jdrueckert jdrueckert deleted the feat/gestalt-8-upgrade branch August 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants