test: Add MTE tests for ItemCommands #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added a commit
that referenced
this pull request
May 24, 2020
jdrueckert
reviewed
May 25, 2020
| character.upsertComponent(InventoryComponent.class, maybeInventory -> maybeInventory.orElse(new InventoryComponent(40))); | ||
|
|
||
| final BlockItemFactory factory = new BlockItemFactory(entityManager); | ||
| final EntityRef blockItem = factory.newInstance(blockManager.getBlockFamily(URI_DIRT), amount); |
There was a problem hiding this comment.
I think you're doing this in #12 as well. We could consider to create a TestUtils class 🤔
There was a problem hiding this comment.
I think this not needed here... at least not as of now... will be tricky enough to figure out what classifies the added block to be "correct"
| //TODO: I don't know what to pass in there, whether it needs to be the player, character, or something else | ||
| itemCommands.give(player, URI_DIRT, amount, null); | ||
|
|
||
| final List<EntityRef> filledSlots = |
There was a problem hiding this comment.
This may be moved to InventoryUtils::filledSlots(InventoryComponent) or InventoryUtils::getItemsFrom(InventoryComponent).
|
❌ 39 tests completed, 3 failed, 8 skipped |
|
this can be closed, @jdrueckert ? |
why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #10