feat(plugins/bk-user-restriction): add new plugin #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pull request #85 titled "feat(plugins/bk-user-restriction): add new plugin" introduces a new plugin called Summary:
The pull request contains 536 additions across 5 files and has 3 commits. |
…le the dict not sorted
piglei
reviewed
Nov 20, 2024
| assert.is_true(core.string.find(ctx.var.bk_apigw_error.error.message, 'bk_username="unknown_user"') ~= nil) | ||
| end) | ||
|
|
||
| it("should allow user not in whitelist", function() |
There was a problem hiding this comment.
这里应该是 should allow user in whitelist
| }, | ||
| }, | ||
| oneOf = { | ||
| { required = { "whitelist" } }, |
There was a problem hiding this comment.
是不是应该在什么地方写插件的文档使用说明，比如我看到这就会好奇两个字段如果都配置会怎么样，理论上字段有互斥。（看了代码的写法，黑名单的优先级是更好，即使 user 命中白名单，仍然可能被黑名单拦下来）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist