fix: oci仓库访问不包含路径的代理源地址时可能无法通过鉴权 #1342 #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
描述：
假设oci仓库设置了不包含路径的代理源地址（url形式为
{scheme}://{domain}而不是{scheme}://{domain}/{path}），当访问该代理源的资源返回401时，oci仓库将根据响应头的内容请求用于获取token的url，此时该url的查询参数scope多了斜杠repository:/{repository}:{accessSet}，导致获取的token在用于后续请求资源时可能无法通过鉴权。