feat: 新增上报 client metrics 数据 #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ambition9186
commented
Dec 25, 2023
Ambition9186
commented
- 客户端上报连接、心跳、变更、拉取事件到 feed-server
- cache-service 定时同步 client metrics 数据到 data-service
- data-service 定时更新客户端离线状态
Ambition9186
force-pushed
the
client_metric
branch
5 times, most recently
from
c609957
to
f07b478
Compare
Ambition9186
force-pushed
the
client_metric
branch
6 times, most recently
from
4f1ea16
to
36d1946
Compare
Ambition9186
force-pushed
the
client_metric
branch
2 times, most recently
from
a098109
to
78ff81e
Compare
Ambition9186
force-pushed
the
client_metric
branch
3 times, most recently
from
e953dec
to
31e27fc
Compare
AlkaidChan
reviewed
Feb 20, 2024
There was a problem hiding this comment.
这个文件在项目中已存在：
pkg/thirdparty/protobuf/google/protobuf/timestamp.proto
| return values, nil | ||
| } | ||
|
|
||
| // RPop 移出并获取列表的第一个元素 |
There was a problem hiding this comment.
前面 LPush 是插入到头部，那这里就应该是从尾部移出并获取一个元素
| logs.Infof("start handle client metric data") | ||
|
|
||
| if !cm.state.IsMaster() { | ||
| logs.V(2).Infof("this is slave, do not need to purge, skip. rid: %s", kt.Rid) |
| return jsoni.Marshal(v) | ||
| } | ||
|
|
||
| // Decode the VersionChangePayload to bytes. |
There was a problem hiding this comment.
// Decode the VersionChangePayload from bytes.
| return jsoni.Marshal(p) | ||
| } | ||
|
|
||
| // Decode the PullStatusPayload to bytes. |
There was a problem hiding this comment.
// Decode the PullStatusPayload from bytes.
| @@ -196,6 +197,99 @@ func (s *Service) Messaging(ctx context.Context, msg *pbfs.MessagingMeta) (*pbfs | |||
| return nil, status.Errorf(codes.PermissionDenied, "no permission to access bscp server") | |||
| } | |||
|
|
|||
| vc := new(sfs.VersionChangePayload) | |||
There was a problem hiding this comment.
这几个变量都只是在对应的 case 中才被引用，不需要提前声明，在对应的 case 中声明就行了
| // ClientMetric xxx | ||
| type ClientMetric struct { | ||
| mc *metric | ||
| client gcache.Cache |
There was a problem hiding this comment.
gcache 是一个内存缓存库，这里客户端数据不需要在 feed_server 内存缓存，它不会被客户端读取，只用往 cache-service 写入就行了。
所以这里去掉这个 client
| } | ||
|
|
||
| // VersionChangePayload defines sdk version change to send payload to feed server. | ||
| type VersionChangePayload struct { |
There was a problem hiding this comment.
这几个 Payload 结构都是一样或者相近的，看到这几个 payload 在 bscp-go 上报的时机也都差不多，可不可以合成一个上报呢
| } | ||
|
|
||
| // ListClientByTuple Query the client list according to multiple fields in | ||
| func (dao *clientDao) ListClientByTuple(kit *kit.Kit, data [][]interface{}) ([]*table.Client, error) { |
There was a problem hiding this comment.
这个注释给全一点，不然传入一个二维 interface{} 数组作为入参有点迷惑
AlkaidChan
reviewed
Feb 20, 2024
| } | ||
|
|
||
| // Run the sync client online state task | ||
| func (c *ClientOnlineState) Run() { |
There was a problem hiding this comment.
这个函数也需要支持主从，只有主服务负责定时同步客户端状态
Ambition9186
force-pushed
the
client_metric
branch
2 times, most recently
from
dcd7ad3
to
9793f68
Compare
2. 新增客户端上报连接、心跳、变更、拉取事件到feed-server 3. 新增cache-service定时同步客户端metrics数据到data-service 4. 新增data-service定时更新客户端离线状态 5. 新增客户端类型字段
Ambition9186
force-pushed
the
client_metric
branch
from
9793f68
to
fc7b67e
Compare
AlkaidChan
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.