代码规范：user-manager lint

bcs-services/bcs-user-manager/app/app.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 // Package app xxx
@@ -47,6 +46,7 @@ func Run(op *options.UserManagerOptions) {
 	component.CacheClusterList()
 
 	if conf.ClientCert.IsSSL {
+		// nolint
 		cliTLS, err := ssl.ClientTslConfVerity(conf.ClientCert.CAFile, conf.ClientCert.CertFile, conf.ClientCert.KeyFile,
 			conf.ClientCert.CertPasswd)
 		if err != nil {
@@ -66,7 +66,7 @@ func Run(op *options.UserManagerOptions) {
 	}
 
 	// init cmdb client
-	if err := cmdb.InitCMDBClient(op); err != nil {
+	if err = cmdb.InitCMDBClient(op); err != nil {
 		blog.Errorf("init cmdb client error: %s", err.Error())
 		os.Exit(1)
 	}

bcs-services/bcs-user-manager/app/pkg/auth/auth.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 // Package auth xxx
@@ -21,8 +20,9 @@ import (
 	"time"
 
 	"github.com/Tencent/bk-bcs/bcs-common/common/blog"
-	"github.com/Tencent/bk-bcs/bcs-services/bcs-user-manager/config"
 	"github.com/parnurzeal/gorequest"
+
+	"github.com/Tencent/bk-bcs/bcs-services/bcs-user-manager/config"
 )
 
 // Auth interface for accessToken

bcs-services/bcs-user-manager/app/pkg/auth/auth_test.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package auth

bcs-services/bcs-user-manager/app/pkg/auth/types.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package auth

bcs-services/bcs-user-manager/app/pkg/cache/cache.go

@@ -8,9 +8,9 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package cache xxx
 package cache
 
 import (

bcs-services/bcs-user-manager/app/pkg/component/client.go

@@ -8,9 +8,9 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package component xxx
 package component
 
 import (
@@ -145,6 +145,7 @@ var defaultTransport http.RoundTripper = &http.Transport{
 	TLSHandshakeTimeout:   10 * time.Second,
 	ExpectContinueTimeout: 1 * time.Second,
 	// NOCC:gas/tls(设计如此)
+	// nolint
 	TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
 }
 

bcs-services/bcs-user-manager/app/pkg/component/cmanager.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package component
@@ -36,10 +35,10 @@ const (
 // CacheClusterList 定时同步 cluster 列表
 func CacheClusterList() {
 	go func() {
-		GetAllCluster()
+		_, _ = GetAllCluster()
 		for range time.Tick(time.Minute) {
 			klog.Infof("list clusters running")
-			GetAllCluster()
+			_, _ = GetAllCluster()
 			klog.Infof("list clusters end")
 		}
 	}()

bcs-services/bcs-user-manager/app/pkg/component/project.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package component

bcs-services/bcs-user-manager/app/pkg/constant/token.go

@@ -8,9 +8,9 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package constant xxx
 package constant
 
 const (
@@ -24,6 +24,7 @@ const (
 	// we can refer to http://coolaf.com/tool/rd when testing
 	DefaultTokenLength = 32
 	// TokenKeyPrefix is the redis key for token
+	// nolint
 	TokenKeyPrefix = "bcs_auth:token:" // NOCC:gas/crypto(误报)
 	// TokenLimits for token
 	TokenLimits = 1

bcs-services/bcs-user-manager/app/pkg/discovery/discovery.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 // Package discovery xxx
@@ -188,6 +187,7 @@ func (sd *ServiceDiscovery) GetRandomServiceInstance() (*registry.Node, error) {
 		return nil, errors.New("allServiceNodes is empty")
 	}
 	// NOCC:gas/crypto(设计如此)
+	// nolint
 	selected := rand.Int() % nodeLength
 	return allServiceNodes[selected], nil
 }

bcs-services/bcs-user-manager/app/pkg/discovery/discovery_test.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package discovery
@@ -36,7 +35,7 @@ func NewRegistry() registry.Registry {
 		registry.Addrs(etcdEndpoints),
 		registry.Secure(false),
 	)
-	etcdRegistry.Init()
+	_ = etcdRegistry.Init()
 
 	return etcdRegistry
 }
@@ -50,6 +49,7 @@ func Test_GetRandomServiceInstance(t *testing.T) {
 		t.Fatalf("start service discovery failed: %v", err)
 	}
 
+	// nolint
 	go func() {
 		for {
 			<-time.After(3 * time.Second)
@@ -65,6 +65,7 @@ func Test_GetRandomServiceInstance(t *testing.T) {
 	signalChan := make(chan os.Signal, 2)
 	signal.Notify(signalChan, syscall.SIGINT, syscall.SIGTERM)
 
+	// nolint
 	select {
 	case <-signalChan:
 		sd.Stop()

bcs-services/bcs-user-manager/app/pkg/encrypt/des.go

@@ -8,16 +8,14 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package encrypt xxx
 package encrypt
 
 import (
 	"bytes"
 	"crypto/cipher"
-
-	// NOCC:gas/crypto(设计如此)
 	"crypto/des"
 	"encoding/base64"
 )
@@ -40,6 +38,7 @@ func PKCS5UnPadding(origData []byte) []byte {
 func DesEncryptToBase(src []byte, priKey string) ([]byte, error) {
 	if len(priKey) != 0 {
 		// NOCC:gas/crypto(设计如此)
+		// nolint
 		block, err := des.NewTripleDESCipher([]byte(priKey))
 		if err != nil {
 			return nil, err
@@ -63,6 +62,7 @@ func DesDecryptFromBase(src []byte, priKey string) ([]byte, error) {
 		}
 		var block cipher.Block
 		// NOCC:gas/crypto(设计如此)
+		// nolint
 		block, err = des.NewTripleDESCipher([]byte(priKey))
 		if err != nil {
 			return nil, err

bcs-services/bcs-user-manager/app/pkg/errors/error.go

@@ -8,9 +8,9 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package errors xxx
 package errors
 
 import "errors"

bcs-services/bcs-user-manager/app/pkg/esb/cmdb/client.go

@@ -10,13 +10,15 @@
  * limitations under the License.
  */
 
+// Package cmdb xxx
 package cmdb
 
 import (
 	"fmt"
 
 	"github.com/Tencent/bk-bcs/bcs-common/common/encrypt"
 	"github.com/Tencent/bk-bcs/bcs-common/pkg/esb/cmdbv3"
+
 	"github.com/Tencent/bk-bcs/bcs-services/bcs-user-manager/options"
 )
 

bcs-services/bcs-user-manager/app/pkg/jwt/jwt.go

@@ -15,6 +15,7 @@ package jwt
 
 import (
 	"github.com/Tencent/bk-bcs/bcs-common/pkg/auth/jwt"
+
 	"github.com/Tencent/bk-bcs/bcs-services/bcs-user-manager/options"
 )
 

bcs-services/bcs-user-manager/app/pkg/lock/etcd/etcd.go

@@ -4,7 +4,7 @@
  * Licensed under the MIT License (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * http://opensource.org/licenses/MIT
- * Unless required by applicable law or agreed to in writing, software distributed under,
+ * Unless required by applicable law or agreed to in writing, software distributed under
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.

bcs-services/bcs-user-manager/app/pkg/lock/lock.go

@@ -4,7 +4,7 @@
  * Licensed under the MIT License (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * http://opensource.org/licenses/MIT
- * Unless required by applicable law or agreed to in writing, software distributed under,
+ * Unless required by applicable law or agreed to in writing, software distributed under
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
@@ -29,14 +29,20 @@ type Options struct {
 }
 
 // LockOptions options for lock
+// NOCC:golint/revive(设计如此:)
+// nolint
 type LockOptions struct {
 	TTL time.Duration
 }
 
 // LockOption option function for lock
+// NOCC:golint/revive(设计如此:)
+// nolint
 type LockOption func(o *LockOptions)
 
 // LockTTL sets the lock ttl
+// NOCC:golint/revive(设计如此:)
+// nolint
 func LockTTL(t time.Duration) LockOption {
 	return func(o *LockOptions) {
 		o.TTL = t

bcs-services/bcs-user-manager/app/pkg/log/log.go

@@ -8,9 +8,9 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package log xxx
 package log
 
 import (

bcs-services/bcs-user-manager/app/pkg/metrics/metrics.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 // Package metrics xxx
@@ -76,6 +75,7 @@ func RunMetric(conf *config.UserMgrConfig) {
 		addresses = append(addresses, conf.IPv6Address)
 	}
 	metricServer := ipv6server.NewIPv6Server(addresses, strconv.Itoa(int(conf.MetricPort)), "", metricMux)
+	// nolint
 	go metricServer.ListenAndServe()
 
 	blog.Infof("run metric ok")

bcs-services/bcs-user-manager/app/pkg/middleware/logging.go

@@ -8,9 +8,9 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package middleware xxx
 package middleware
 
 import (
@@ -29,7 +29,7 @@ import (
 func LoggingFilter(request *restful.Request, response *restful.Response, chain *restful.FilterChain) {
 	inBody, err := io.ReadAll(request.Request.Body)
 	if err != nil {
-		response.WriteError(400, err)
+		_ = response.WriteError(400, err)
 		return
 	}
 	blog.Log(request.Request.Context()).Infof("url: %s, method: %s, request: %s", request.Request.URL,

bcs-services/bcs-user-manager/app/pkg/middleware/project.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package middleware

bcs-services/bcs-user-manager/app/pkg/middleware/requestid.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package middleware

bcs-services/bcs-user-manager/app/pkg/middleware/tracing.go

@@ -8,7 +8,6 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
 package middleware
@@ -55,6 +54,8 @@ func TracingFilter(request *restful.Request, response *restful.Response, chain *
 		// get http X-Request-Id
 		requestID := request.Request.Header.Get(constant.RequestIDHeaderKey)
 		// 使用requestID当作TraceID
+		// NOCC:golint/staticcheck(设计如此:)
+		// nolint
 		ctx = context.WithValue(ctx, constant.RequestIDKey, requestID)
 		ctx = traceUtil.ContextWithRequestID(ctx, requestID)
 	}
@@ -91,7 +92,7 @@ func TracingFilter(request *restful.Request, response *restful.Response, chain *
 	}
 	span.SetAttributes(attribute.Key("query").String(query))
 
-	//记录body
+	// 记录body
 	body := string(getRequestBody(request.Request))
 	if len(body) > 1024 {
 		body = fmt.Sprintf("%s...(Total %s)", body[:1024], humanize.Bytes(uint64(len(body))))

bcs-services/bcs-user-manager/app/pkg/parser/register.go

@@ -8,9 +8,9 @@
  * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
  * either express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
- *
  */
 
+// Package parser xxx
 package parser
 
 import (