Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: bscp cmd/ lint #2640

Merged
merged 18 commits into from
Oct 8, 2023
Merged

feature: bscp cmd/ lint #2640

merged 18 commits into from
Oct 8, 2023

Conversation

linfang-canway
Copy link
Contributor

bscp/cmd 代码规范

@linfang-canway
fix：
a748339 
- 规范代码
@linfang-canway
fix：
8a0d458 
- 规范代码
@linfang-canway
fix：
40fe66c 
- 规范代码
@linfang-canway
// nolint
0a317a6 
=>
//nolint
AlkaidChan
AlkaidChan reviewed Sep 27, 2023
View reviewed changes
bcs-services/bcs-bscp/cmd/api-server/service/routers.go Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/cache-service/service/cache/keys/cache.go Outdated Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/data-service/db-migration/migrator/migrator.go Outdated Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/data-service/db-migration/migrator/migrator.go Outdated Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/data-service/service/config_item.go Outdated Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/data-service/service/config_item.go Outdated Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/data-service/service/group.go Outdated Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/vault-server/vault-plugins/main.go Outdated Show resolved Hide resolved
bcs-services/bcs-bscp/cmd/vault-server/vault-plugins/service/backend_test.go Show resolved Hide resolved
@linfang-canway
Merge remote-tracking branch 'TencentBlueKing/master' into bscp-code-ci
ff9c14f 
# Conflicts:
#	bcs-services/bcs-bscp/cmd/vault-server/vault-sidecar/server.go
@linfang-canway
code-ci
4ff97eb
@linfang-canway
1. // nolint => //nolint
01d9f9b 
2. 优化 tx.Rollback() 打印信息
@linfang-canway
golint
229be65
AlkaidChan
AlkaidChan approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@AlkaidChan AlkaidChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlkaidChan AlkaidChan merged commit 97aa27a into TencentBlueKing:master Oct 8, 2023
5 checks passed
wenxinlee2015 added a commit that referenced this pull request Oct 10, 2023
@wenxinlee2015
Merge remote-tracking branch 'github-bk-bcs/master'
383eeda 
* github-bk-bcs/master:
  feat：优化删除服务二次确认 (#2671)
  Fix/lint style (#2669)
  fix：修复部分空间bug和空状态规范 (#2670)
  upd：处理eslint规范 (#2668)
  feature:  bscp cmd/ lint (#2640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fireyun fireyun fireyun left review comments

@AlkaidChan AlkaidChan AlkaidChan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linfang-canway @fireyun @AlkaidChan