-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Labyrinth - Viktoria O. #7
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found my way through I nice and well built maze! I like the design and the theme.
I think the code is very well structured, clean and understandable. Each component handles what it feels like it should do and nothing more, making it easier to follow along.
Fun to see a different approach on how you solved the task with different images for each scene using a json file.
You achieve the requirements and even some of the stretch goals! You should be really proud with what you have accomplished, both the code and the design looks really great🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the retro feeling! Feels fitting ⭐ Keep up the good work.
import Lottie from "lottie-react"; | ||
import animationData from "../../animation.json"; | ||
import "./Loading.css" | ||
|
||
export const Loading = () => { | ||
return ( | ||
<div className="loader"> | ||
<Lottie animationData={animationData} /> | ||
</div> | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice loader ⭐
|
||
export const Scene = () => { | ||
const { locationDescription, coordinates } = useLabyrinthStore(); | ||
const image = locationImage.find((img) => img.imgCoordinates === coordinates); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution!
<input | ||
type="text" | ||
value={playerName} | ||
placeholder="Enter your name" | ||
onChange={(event) => setPlayerName(event.target.value)} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you'd want to account for missing input here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well structured store! toggleHidden and startGame are great names for functions. Maybe the last one could be called something like makeNextMove to follow the same structure?
Netlify link
https://gleaming-panda-f1e201.netlify.app/
Collaborators
Solo project