Alma and Wen - Labyrinth project #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Movement logic
Style start page
Add some background images and make restart button work to change background
HIPPIEKICK
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Structured store and well named states and actions, well done ⭐
| set({ | ||
| coordinates: data.coordinates, | ||
| description: data.description, | ||
| actions: data.actions, |
There was a problem hiding this comment.
Would be nice if you also saved the description of the actions, that's quite a big part of the game 👀
Comment on lines
+5
to
+7
| <> | ||
| <FirstPage /> | ||
| </> |
There was a problem hiding this comment.
No need for fragments when you're only returning one element
| error: null, | ||
| loggedIn: false, | ||
| startGame: async (name) => { | ||
| const encryptedName = name + new Date() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://alma-wen-labyrinth.netlify.app/
Collaborators
[almaherris]