Maze #13
Open
Maze #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Apr 26, 2024
src/App.css
Outdated
src/App.jsx
Outdated
Comment on lines
14
to
18
| useEffect(() => { | ||
| // start("Maze Man"); | ||
| }, []); | ||
|
|
||
| console.log(gameState); |
src/Game.css
Outdated
Comment on lines
1
to
4
| .Game { | ||
| } | ||
|
|
||
| .Game-description { |
There was a problem hiding this comment.
Remove unused code throughout your whole app. And make sure to always name CSS class names in kebab-case
| <button | ||
| // ${action.direction} is a template literal, it will be replaced with the value of action.direction | ||
| className={`Game-navigate ${action.direction}`} | ||
| disabled={loading} |
There was a problem hiding this comment.
Very nice! As you know, one of the requirements this week is:
- Focus on making the UX of your app good. Handle the response delay
and I think it would be very nice with some kind of loading indicator, but on the other hand you have actually handled the response delay by disabling the buttons, so 👍
src/store.js
Outdated
| username: "", | ||
| // here we are declaring the loading after pressing button | ||
| loading: false, | ||
| gameState: undefined, |
There was a problem hiding this comment.
Your store has the things that is needed and is structured properly 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://mazzze.netlify.app