Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W11-Mars Labyrinth #11

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

W11-Mars Labyrinth #11

wants to merge 18 commits into from

Conversation

Maria-Manuela
Copy link

Copy link

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I like the Mars theme 🚀 If you will continue working on this, it would be nice if the opening of " 👁️ Show descriptions" where smoothly animated and that the descriptions were aligned:
Skärmavbild 2024-04-26 kl  10 23 15

Comment on lines +5 to +7
<div>
<StartComponent />
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this div? 👀

);
};

// GameComponent should focus solely on rendering the game UI and handling actions. */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could also be a named Export to follow the structure of your other components

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well structured store and well named variables! Make sure to remove console.logs and unused code + be consistent with single/double quotes (check your whole project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants