Feat : 학사 일정 api 수정 #172
Merged
Feat : 학사 일정 api 수정 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwoo-jo
added
🎨 DESIGN
m6z1
requested changes
Feb 24, 2024
app/src/main/java/com/dongyang/android/youdongknowme/data/remote/service/CafeteriaService.kt
Outdated
Show resolved
Hide resolved
Comment on lines
19
to
26
| inner class ViewHolder(private val binding: ItemScheduleBinding) | ||
| : RecyclerView.ViewHolder(binding.root) { | ||
| fun bind(item : Schedule) { | ||
| binding.schedule = item | ||
| } | ||
| fun bind(item: ScheduleEntry) { | ||
| binding.schedule = item | ||
| binding.tvItemScheduleDate.text = if(item.date[0] == item.date[1]) item.date[0] else "${item.date[0]} ~ \n${item.date[1]}" | ||
| binding.tvItemScheduleContents.text = item.content | ||
| } | ||
| } |
There was a problem hiding this comment.
inner class 에 관해서 정리된 아티클인데 한 번 읽어보시면 좋을 것 같아요
블로그 링크
| stuKoreanMenuAdapter.submitList(it.first) | ||
| stuAnotherMenuAdapter.submitList(it.second) | ||
| viewModel.menus.observe(viewLifecycleOwner) { | ||
| stuKoreanMenuAdapter.submitList(it) |
There was a problem hiding this comment.
stu가 어떤 것의 약자인가요 ? 최대한 줄여쓰는 것을 지양하면 좋을 것 같습니다!
There was a problem hiding this comment.
student의 약자인데 기존 코드를 그대로 적으면서 리팩토링을 생각 못 했네요
그리고 이 부분은 메뉴 브랜치의 코드가 섞여버린거 같습니다..🤔
There was a problem hiding this comment.
이 부분은 학식 관련 리펙토링 브랜치를 따로 만들어서 바꾸는게 좋을거 같습니다
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/schedule/ScheduleFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/schedule/ScheduleFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/schedule/ScheduleViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/schedule/ScheduleViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/schedule/ScheduleViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/adapter/ScheduleAdapter.kt
Show resolved
Hide resolved
hoyahozz
requested changes
Feb 27, 2024
| @SerializedName("etc_info") | ||
| var etcInfo: String, | ||
| @SerializedName("menus") | ||
| val menu: List<String> |
There was a problem hiding this comment.
Suggested change
| val menu: List<String> | |
| val menus: List<String> |
가독성을 위해 컬렉션은 복수형태로 이름 지어주시면 좋을 것 같아요~
There was a problem hiding this comment.
메뉴 관련 브랜치를 따로 제작하여 위에 stu 수정과 같이 수정하는게 좋을거 같습니다.
app/src/main/java/com/dongyang/android/youdongknowme/data/remote/entity/Schedule.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/data/remote/entity/Schedule.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/schedule/ScheduleViewModel.kt
Outdated
Show resolved
Hide resolved
huiwoo-jo
force-pushed
the
feature/api-schedule
branch
from
f0f955b
to
3c703b4
Compare
hoyahozz
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
✍️ 구현 내용
📷 구현 영상
✔️ 확인 사항