Merge pull request #267 from Tantalor93/donotshadow

do not share err variable between worker goroutines
Tantalor93 · Jun 2, 2024 · 5e876f3 · 5e876f3
2 parents 037b753 + 044ae2f
commit 5e876f3
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/dnsbench/benchmark.go b/pkg/dnsbench/benchmark.go
@@ -363,7 +363,6 @@ func (b *Benchmark) Run(ctx context.Context) ([]*ResultStats, error) {
 		st := newResultStats(b)
 		stats[w] = st
 
-		var err error
 		wg.Add(1)
 		go func(workerID uint32, st *ResultStats) {
 			defer func() {
@@ -400,7 +399,6 @@ func (b *Benchmark) Run(ctx context.Context) ([]*ResultStats, error) {
 								return
 							}
 						}
-						var resp *dns.Msg
 
 						req := dns.Msg{}
 						req.RecursionDesired = b.Recurse
@@ -433,7 +431,7 @@ func (b *Benchmark) Run(ctx context.Context) ([]*ResultStats, error) {
 						start := time.Now()
 
 						reqTimeoutCtx, cancel := context.WithTimeout(ctx, b.RequestTimeout)
-						resp, err = query(reqTimeoutCtx, b.Server, &req)
+						resp, err := query(reqTimeoutCtx, b.Server, &req)
 						cancel()
 						dur := time.Since(start)
 						if b.RequestLogEnabled {