Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.12 tests #16

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Fix Python 3.12 tests #16

merged 3 commits into from
Apr 29, 2024

Conversation

TabulateJarl8
Copy link
Owner

There was a bug that came up in Python 3.12 where the settings checkbox went off the screen, causing a test to fail. I increased the width of the settings screen from 50% to 75% which seems to have fixed the issue. I also added a slight margin to the container to make the UI look slightly better.

Closes #15

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd033ae) to head (1b00f9e).

❗ Current head 1b00f9e differs from pull request most recent head 71f634d. Consider uploading reports for the commit 71f634d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          323       336   +13     
=========================================
+ Hits           323       336   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TabulateJarl8 TabulateJarl8 merged commit 968888d into master Apr 29, 2024
5 checks passed
@TabulateJarl8 TabulateJarl8 deleted the fix_py312_tests branch April 29, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 Tests Fail
1 participant