-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Adjust/Hide Events/Courses #170
Open
PSandro
wants to merge
20
commits into
TUM-Dev:master
Choose a base branch
from
PSandro:fr-filter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
changed the title
FR: Filter out Events/Courses
Feature: Filter out Events/Courses
Jan 9, 2024
PSandro
changed the title
Feature: Filter out Events/Courses
Feature: Adjust/Hide Events/Courses
Jan 15, 2024
In order to be able to prefill the course adjustment page with previously selected values, we would need to have the user provide his https://campus.tum... link instead of https://cal.tum.ap... It's probably better to just store the settings in the browser and load them when revisiting the site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #144
It is now possible to deselect specific events/courses after providing calendar link URL to CalendarProxy.
As discussed in #144, there are multiple ways to approach the filtering. It can be done by tag, by the full course name or the
X-CO-RECURRINGID
included in the event series.For now, the full course name is used.
It is planned to also provide a feature for adjusting start- and endtimes of events. I'm unsure yet if this should be included here or in a followup PR.