-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salti solutions improvements #66
Draft
SiggyF
wants to merge
44
commits into
master
Choose a base branch
from
SALTISolutions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TNSim into SALTISolutions
- Removal of lock.CustomLog-class - Creation of vessel.IsVessel-class - Resolved a positional bug in lock-module - Some changes to the core to limit input parameters vessel - Creation of Is/Has LockComplex-class, including a automated time-distance diagram plot - VesselTrafficService is now a simpyobject, having an environment - Created a DiGraph class that can be used to easily create a graph from a list of tuples including two Node-class objects - Various other small changes
…TNSim into SALTISolutions # Conflicts: # notebooks/Examples_locking_module/Example Two Locks on a Graph.ipynb # notebooks/Examples_locking_module/Example XX - Graph + energy, fuel use and emissions.ipynb # notebooks/Examples_locking_module/Example XX - Graph + one lock v2.ipynb # notebooks/Examples_locking_module/Example XX - Graph + two locks v2.ipynb
… of test - requires further attention)
…ion modules still WIP
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion is to cherry pick these improvements into separate merge branches.