Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salti solutions improvements #66

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from
Draft

Salti solutions improvements #66

wants to merge 44 commits into from

Conversation

SiggyF
Copy link
Contributor

@SiggyF SiggyF commented May 1, 2024

Suggestion is to cherry pick these improvements into separate merge branches.

PanaderoCF and others added 30 commits April 11, 2024 11:01
- Removal of lock.CustomLog-class
- Creation of vessel.IsVessel-class
- Resolved a positional bug in lock-module
- Some changes to the core to limit input parameters vessel
- Creation of Is/Has LockComplex-class, including a automated time-distance diagram plot
- VesselTrafficService is now a simpyobject, having an environment
- Created a DiGraph class that can be used to easily create a graph from a list of tuples including two Node-class objects
- Various other small changes
…TNSim into SALTISolutions

# Conflicts:
#	notebooks/Examples_locking_module/Example Two Locks on a Graph.ipynb
#	notebooks/Examples_locking_module/Example XX - Graph + energy, fuel use and emissions.ipynb
#	notebooks/Examples_locking_module/Example XX - Graph + one lock v2.ipynb
#	notebooks/Examples_locking_module/Example XX - Graph + two locks v2.ipynb
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants