forked from swcarpentry/r-novice-inflammation
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test functions right away, package code & tests later together #19
Draft
katrinleinweber
wants to merge
20
commits into
gh-pages
Choose a base branch
from
DEV-test-first-package-second
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move package install instructions & reiteration forward
Also shuffle questions, objectives, keypoints and a few content paragraphs accordingly
katrinleinweber
force-pushed
the
DEV-test-first-package-second
branch
2 times, most recently
from
April 8, 2019 12:47
39de639
to
c6d69b4
Compare
katrinleinweber
force-pushed
the
gh-pages
branch
from
April 8, 2019 12:47
d826469
to
e80c695
Compare
katrinleinweber
force-pushed
the
DEV-test-first-package-second
branch
from
April 8, 2019 12:48
c6d69b4
to
171139a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is lowest prio, compared to the others. Its commits start after the last
Merge ... INTEGRATE
commit and show an example of how testing could be taught right after creating functions, possibly even before documenting them.Comments are welcome, even on this draft, but best in the commits, rather than as reviews of this PR.
testthat
or even into packagingmake site
results