Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement grid mode clip edit & launch - feedback appreciated. Implements #1909 #2868

Draft
wants to merge 4 commits into
base: community
Choose a base branch
from

Conversation

RJ-Eckie
Copy link
Contributor

@RJ-Eckie RJ-Eckie commented Nov 3, 2024

This implements a way to edit and launch a clip in grid mode with one action.

Changes to edit mode:

Edit mode is now either launching or non-launching:

  • Blue: non-launching (unchanged)
  • Cyan: identical to blue, but whenever a clip is entered that clip is also launched (quantized, or immediately when holding shift)

Launching/non-launching mode can be toggled by pressing green+blue at the same time
Launching is quantized. (Immediate launching with shift+cyan to be implemented.)

Changes to copying in grid mode:

Copying now has three variants:

  • Launch mode: after copying, remain in grid view (unchanged)
  • Edit mode, non-launching: after copying, enters newly created clip
  • Edit mode, launching: after copying, enters newly created clip and launches it

--

This addresses all complaints in #1909 and even goes a step further. Especially when copying + launching it feels really smooth! Interested to hear what other people think.

Copy link
Contributor

github-actions bot commented Nov 3, 2024

Test Results

103 tests  ±0   103 ✅ ±0   0s ⏱️ ±0s
 15 suites ±0     0 💤 ±0 
 15 files   ±0     0 ❌ ±0 

Results for commit a012c0b. ± Comparison against base commit abe9158.

♻️ This comment has been updated with latest results.

@RJ-Eckie
Copy link
Contributor Author

RJ-Eckie commented Nov 3, 2024

Ready for review as far as I'm concerned. Happy to make changes if there's feedback.

@RJ-Eckie RJ-Eckie marked this pull request as ready for review November 3, 2024 21:54
@seangoodvibes seangoodvibes added this to the Release 1.3 milestone Nov 4, 2024
@RJ-Eckie RJ-Eckie marked this pull request as draft November 8, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants